[Fix] Add ignore_keys in ConcatDataset
#556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BIGWangYuDong
changed the title
ignore_keys in ConcatDataset
HAOCHENYE
reviewed
Sep 30, 2022
HAOCHENYE
reviewed
Sep 30, 2022
|
This PR resolves #559 and open-mmlab/mmdetection#8847 |
HAOCHENYE
reviewed
Oct 11, 2022
|
Hi @BIGWangYuDong, please merge the upstream main branch to fix the lint error. Besides, unit tests should be added to cover the modification. |
zhouzaida
reviewed
Oct 12, 2022
zhouzaida
reviewed
Oct 12, 2022
zhouzaida
reviewed
Oct 13, 2022
zhouzaida
reviewed
Oct 13, 2022
zhouzaida
reviewed
Oct 13, 2022
BIGWangYuDong
requested review from
zhouzaida and
HAOCHENYE
and removed request for
HAOCHENYE and
zhouzaida
BIGWangYuDong
requested review from
zhouzaida and
HAOCHENYE
and removed request for
zhouzaida and
HAOCHENYE
BIGWangYuDong
commented
Oct 19, 2022
BIGWangYuDong
requested review from
HAOCHENYE
and removed request for
zhouzaida
zhouzaida
reviewed
Oct 21, 2022
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
BIGWangYuDong
requested review from
zhouzaida
and removed request for
HAOCHENYE
HAOCHENYE
reviewed
Oct 27, 2022
BIGWangYuDong
requested review from
HAOCHENYE
and removed request for
zhouzaida
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
HAOCHENYE
approved these changes
Oct 31, 2022
ly015
pushed a commit
to ly015/mmengine
that referenced
this pull request
Nov 9, 2022
* [Fix] Fix ConcatDataset error in VOCDataset * minor fix * minor fix * minor fix * add UT * minor fix * minor fix * minor fix * Update mmengine/dataset/dataset_wrapper.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> * minor fix * Update mmengine/dataset/dataset_wrapper.py Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there are some unnecessary keys in dataset.metainfo, but in ConcatDataset, it is forced to set all dataset.metainfo equal. In this PR, we add an
ignore_keyto avoid some unnecessary keys not equal in some concat dataset.Related PR: open-mmlab/mmdetection#8847