Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix merge ci & multiprocessing unit test #529

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Sep 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  1. Fix merge workflow(skip some unit tests in windows).
  2. Change timeout of MultiProcessTestCase from 500 to 1000, since multiprocessing unit test in windows could not be completed 500s.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 77.68% // Head: 77.68% // No change to project coverage 👍

Coverage data is based on head (1519689) compared to base (6b1b8a3).
Patch has no changes to coverable lines.

❗ Current head 1519689 differs from pull request most recent head 857bc93. Consider uploading reports for the commit 857bc93 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #529   +/-   ##
=======================================
  Coverage   77.68%   77.68%           
=======================================
  Files         116      116           
  Lines        8612     8612           
  Branches     1778     1778           
=======================================
  Hits         6690     6690           
  Misses       1623     1623           
  Partials      299      299           
Flag Coverage Δ
unittests 77.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HAOCHENYE HAOCHENYE changed the title [WIP] Fix merge ci & multiprocessing unit test [Fix] Fix merge ci & multiprocessing unit test Sep 13, 2022
@ZwwWayne ZwwWayne merged commit ca0364b into open-mmlab:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants