Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] wandb define_metric #509

Merged
merged 3 commits into from
Sep 7, 2022
Merged

[Enhancement] wandb define_metric #509

merged 3 commits into from
Sep 7, 2022

Conversation

okotaku
Copy link
Contributor

@okotaku okotaku commented Sep 3, 2022

Motivation

Related to open-mmlab/mmcv#2237

Use cases (Optional)

vis_backends = [
    dict(type='LocalVisBackend'),
    dict(
        type='WandbVisBackend',
        init_kwargs=dict(
            project='project', name='expname'),
        define_metric_cfg={'coco/bbox_mAP': 'max'})
]

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne added the P1 label Sep 5, 2022
@ZwwWayne ZwwWayne added this to the 0.2.0 milestone Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@ba1c368). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7e31ee7 differs from pull request most recent head 379113f. Consider uploading reports for the commit 379113f to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage        ?   77.51%           
=======================================
  Files           ?      116           
  Lines           ?     8607           
  Branches        ?     1777           
=======================================
  Hits            ?     6672           
  Misses          ?     1639           
  Partials        ?      296
Flag Coverage Δ
unittests 77.51% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@okotaku okotaku requested review from ZwwWayne and removed request for hhaAndroid and Harold-lkk September 5, 2022 02:41
@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Sep 6, 2022

Hi @okotaku ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
image

@okotaku
Copy link
Contributor Author

okotaku commented Sep 6, 2022

@ZwwWayne The lint issue is same as this.

@okotaku okotaku requested a review from ZwwWayne September 6, 2022 04:12
@ZwwWayne ZwwWayne merged commit cfb884c into open-mmlab:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

Assignees
No one assigned
Labels
P1
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@okotaku @ZwwWayne