[Fix] Fix the logic of setting lazy_import #1239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure case:
a config which is allowed by previous mmengine:
This is non-lazy_import, hence i provide a hack arg in train.py:
But there is still auto lazy_import detected:
I find auto detecting lazy_import maintains in
_file2dict()
.But If a user provide
lazy_import=False
, why auto detecting lazy_import again? If whether lazy_import is True or False, it must be equal toConfig._is_lazy_import(filename)
, what is the meaning oflazy_import=False
arg.Solutions:
lazy_import
arg to_file2dict()
(but_file2dict()
seems customized for non-lazy_import, seems not pretty)self.lazy_import
attribute.