Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Enhance config #1232

Merged
merged 4 commits into from
Jul 5, 2023
Merged

[Enhance] Enhance config #1232

merged 4 commits into from
Jul 5, 2023

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. Support dump config without formatting the code
  2. Support dump pure Python style config to json and yaml.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

zhouzaida
zhouzaida previously approved these changes Jul 4, 2023
@mzr1996
Copy link
Member

mzr1996 commented Jul 5, 2023

Why don't set it as an argument of dump?

@HAOCHENYE
Copy link
Collaborator Author

Why don't set it as an argument of dump?

This argument should also be used by pretty_text

@HAOCHENYE
Copy link
Collaborator Author

Approved!!!
image

@zhouzaida zhouzaida merged commit 8d4bac2 into open-mmlab:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants