[Enhance] Complement type hint of get_model_complexity_info() #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sjiang95 , thanks for your contribution. Please resolve the conflicting files and fix the lint. |
sjiang95
force-pushed
the
inputstypehint
branch
2 times, most recently
from
0814d18 to
bc8e5ba
Compare
The type of `inputs` should be one of `torch.Tensor`, `tuple[torch.Tensor, ...]` and `None`. Signed-off-by: Shengjiang QUAN <qsj287068067@126.com>
sjiang95
force-pushed
the
inputstypehint
branch
from
bc8e5ba to
ec64498
Compare
|
Hi @zhouzaida, thanks for your quick response. |
zhouzaida
approved these changes
Apr 10, 2023
Hi @sjiang95, hanks for your contribution. I have approved and it can be merged after passing the CI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
=======================================
Coverage ? 76.41%
=======================================
Files ? 139
Lines ? 11203
Branches ? 2253
=======================================
Hits ? 8561
Misses ? 2280
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of
inputsshould be one oftorch.Tensor,tuple[torch.Tensor, ...]andNone.Motivation
The type hint of arg
inputsinget_model_complexity_info()should matchclass FlopAnalyzermmengine/mmengine/analysis/complexity_analysis.py
Line 121 in 5e1ed7a
and
class ActivationAnalyzer,mmengine/mmengine/analysis/complexity_analysis.py
Line 192 in 5e1ed7a
since the argument
inputsis finally fed into these two classes.Otherwise, a user may be confused about what if a custom model requires more than one tensors as inputs.
Modification
Change current type hint of
inputsinget_model_complexity_info()fromto
BC-breaking (Optional)
Not applicable.
Use cases (Optional)
Not applicable.
Checklist