Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] No training log when the num of iterations is smaller than the default interval #1046

Merged
merged 7 commits into from
Apr 24, 2023
Merged

[Fix] No training log when the num of iterations is smaller than the default interval #1046

merged 7 commits into from
Apr 24, 2023

Conversation

shufanwu
Copy link
Contributor

@shufanwu shufanwu commented Apr 3, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

No training log when the num of iterations is smaller than the default interval. https://github.com/open-mmlab/mmengine/issues/935

Modification

Add judgement in function after_train_iter of class LoggerHook.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

HAOCHENYE
HAOCHENYE reviewed Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution. The modification makes sense to me, but should we also update the after_val_iter and after_test_iter?

@shufanwu
Copy link
Contributor Author

shufanwu commented Apr 4, 2023 •
edited
Loading

Hi, thanks for your contribution. The modification makes sense to me, but should we also update the after_val_iter and after_test_iter?

I think we don't need to update these because in val or test task, the loggerhook after_val_epoch and after_test_epoch will be called after each epoch.

@shufanwu shufanwu requested a review from HAOCHENYE April 6, 2023 13:11
@HAOCHENYE
Copy link
Collaborator

Hi, thanks for your contribution. The modification makes sense to me, but should we also update the after_val_iter and after_test_iter?

I think we don't need to update these because in val or test task, the loggerhook after_val_epoch and after_test_epoch will be called after each epoch.

It makes sense to me 👍

@zhouzaida zhouzaida linked an issue Apr 7, 2023 that may be closed by this pull request
[Bug] No training log when the num of iterations smaller than default interval #935
Closed
2 tasks
@zhouzaida zhouzaida mentioned this pull request Apr 7, 2023
Open
@shufanwu shufanwu requested a review from HAOCHENYE April 10, 2023 13:31
@HAOCHENYE
Copy link
Collaborator

Hi! Could you add a unit test for LoggerHook to validate that the logs will be output when the length of the train dataloader is smaller than the log interval?

@HAOCHENYE
Copy link
Collaborator

Hi, it could be more proper to add unit test here, and we should test runner.logger.info will be called when the length of dataloader is smaller than the log interval.

@HAOCHENYE HAOCHENYE added this to the 0.7.3 milestone Apr 23, 2023
zhouzaida
zhouzaida previously approved these changes Apr 24, 2023
View reviewed changes
@zhouzaida zhouzaida merged commit 2aef53d into open-mmlab:main Apr 24, 2023
@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@83c4f3e). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage        ?   77.89%           
=======================================
  Files           ?      139           
  Lines           ?    11300           
  Branches        ?     2279           
=======================================
  Hits            ?     8802           
  Misses          ?     2103           
  Partials        ?      395
Flag Coverage Δ
unittests 77.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

@HAOCHENYE HAOCHENYE Awaiting requested review from HAOCHENYE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.

[Bug] No training log when the num of iterations smaller than default interval
3 participants
@shufanwu @HAOCHENYE @zhouzaida