Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] get_device and is_npu_available #1004

Merged
merged 2 commits into from
Mar 19, 2023
Merged

[Refactor] get_device and is_npu_available #1004

merged 2 commits into from
Mar 19, 2023

Conversation

C1rN09
Copy link
Collaborator

@C1rN09 C1rN09 commented Mar 17, 2023 •
edited
Loading

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Determine devices on initialization instead of whenever get_device is called.

Determine the availability of NPU devices on initialization instead of whenever is_npu_available is called.

Modification

Add new variables IS_NPU_AVAILABLE and DEVICE

BC-breaking (Optional)

No

Use cases (Optional)

Not changed

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@C1rN09 C1rN09 requested a review from zhouzaida as a code owner March 17, 2023 07:24
@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@ff27b72). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 1cb2ad5 differs from pull request most recent head b19ae56. Consider uploading reports for the commit b19ae56 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage        ?   76.58%           
=======================================
  Files           ?      139           
  Lines           ?    11034           
  Branches        ?     2207           
=======================================
  Hits            ?     8450           
  Misses          ?     2217           
  Partials        ?      367
Flag Coverage Δ
unittests 76.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

zhouzaida
zhouzaida reviewed Mar 17, 2023
View reviewed changes
mmengine/device/utils.py Outdated Show resolved Hide resolved
@C1rN09 @zhouzaida
Update mmengine/device/utils.py
b19ae56 
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida zhouzaida merged commit cbb6714 into open-mmlab:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C1rN09 @zhouzaida