Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Add reduction_override in MSELoss #5437

Merged
merged 3 commits into from
Jun 29, 2021
Merged

[Refactor] Add reduction_override in MSELoss #5437

merged 3 commits into from
Jun 29, 2021

Conversation

BIGWangYuDong
Copy link
Collaborator

Add reduction_override in MSELoss.

When using MSELoss replace L1Loss in Faster R-CNN or Mask R-CNN, may get a bug, this PR adds reduction_override Args in MSELoss.

@BIGWangYuDong BIGWangYuDong requested a review from jshilong June 24, 2021 09:53
@codecov
Copy link

codecov bot commented Jun 24, 2021 •
edited
Loading

Codecov Report

Merging #5437 (9ae199c) into master (bbd03fb) will decrease coverage by 0.29%.
The diff coverage is 50.63%.

❗ Current head 9ae199c differs from pull request most recent head 9ca9345. Consider uploading reports for the commit 9ca9345 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5437      +/-   ##
==========================================
- Coverage   64.88%   64.59%   -0.30%     
==========================================
  Files         276      276              
  Lines       21347    21382      +35     
  Branches     3543     3563      +20     
==========================================
- Hits        13851    13811      -40     
- Misses       6744     6818      +74     
- Partials      752      753       +1
Flag Coverage Δ
unittests 64.55% <50.63%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/core/export/pytorch2onnx.py 14.03% <ø> (ø)
mmdet/datasets/pipelines/test_time_aug.py 95.55% <ø> (-0.10%) ⬇️
mmdet/models/dense_heads/autoassign_head.py 96.17% <ø> (ø)
mmdet/models/necks/pafpn.py 38.29% <ø> (-1.29%) ⬇️
mmdet/models/roi_heads/bbox_heads/bbox_head.py 74.01% <0.00%> (-1.47%) ⬇️
...det/models/roi_heads/mask_heads/mask_point_head.py 31.53% <0.00%> (-1.18%) ⬇️
mmdet/models/roi_heads/standard_roi_head.py 50.31% <ø> (ø)
mmdet/models/roi_heads/test_mixins.py 57.25% <0.00%> (ø)
mmdet/models/roi_heads/point_rend_roi_head.py 16.09% <10.14%> (-3.54%) ⬇️
mmdet/models/backbones/ssd_vgg.py 64.44% <14.28%> (-1.47%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd03fb...9ca9345. Read the comment docs.

@ZwwWayne
Copy link
Collaborator

Need unit tests.

@jshilong
Copy link
Collaborator

add unit tests especially for the override

@ZwwWayne ZwwWayne merged commit 33bc4c5 into open-mmlab:master Jun 29, 2021
@BIGWangYuDong BIGWangYuDong deleted the fix_mse_loss branch June 30, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

@jshilong jshilong Awaiting requested review from jshilong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BIGWangYuDong @ZwwWayne @jshilong