Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type of runner in configs #4669

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Conversation

ZwwWayne
Copy link
Collaborator

@ZwwWayne ZwwWayne commented Feb 24, 2021

This PR fixes bugs caused by #4570 by adding types of runners in all configs that do not specify the runner type, which also serves as a reminder.

fix #4649, fix #4668

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #4669 (4662568) into master (14d250f) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4669      +/-   ##
==========================================
- Coverage   64.19%   64.01%   -0.18%     
==========================================
  Files         251      251              
  Lines       19393    19393              
  Branches     3265     3265              
==========================================
- Hits        12449    12415      -34     
- Misses       6293     6330      +37     
+ Partials      651      648       -3     
Flag Coverage Δ
unittests 63.99% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/roi_heads/mask_scoring_roi_head.py 55.35% <0.00%> (-32.15%) ⬇️
mmdet/models/roi_heads/test_mixins.py 45.03% <0.00%> (-8.40%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 94.62% <0.00%> (-5.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d250f...7f9de81. Read the comment docs.

@ZwwWayne ZwwWayne merged commit f52dac8 into open-mmlab:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't train voc dataset meet " KeyError: 'cfg or default_args must contain the key "type", but got.."
2 participants