Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittest #325

Merged
merged 37 commits into from
Nov 11, 2020
Merged

Add unittest #325

merged 37 commits into from
Nov 11, 2020

Conversation

kennymckormick
Copy link
Member

No description provided.

@innerlee
Copy link
Contributor

innerlee commented Nov 9, 2020

The two mp4 files are too large, could you reduce their sizes?

image

@innerlee innerlee requested a review from dreamerlin November 9, 2020 12:43
@codecov
Copy link

codecov bot commented Nov 9, 2020 •
edited
Loading

Codecov Report

Merging #325 (ada035e) into master (3bd9a22) will increase coverage by 2.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   83.45%   85.78%   +2.33%     
==========================================
  Files          97       97              
  Lines        6799     6797       -2     
  Branches     1104     1104              
==========================================
+ Hits         5674     5831     +157     
+ Misses        919      750     -169     
- Partials      206      216      +10
Flag Coverage Δ
unittests 85.77% <ø> (+2.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/rawvideo_dataset.py 93.75% <ø> (+71.02%) ⬆️
mmaction/core/evaluation/accuracy.py 91.90% <0.00%> (-0.96%) ⬇️
mmaction/datasets/hvu_dataset.py 96.05% <0.00%> (+28.94%) ⬆️
mmaction/core/evaluation/eval_detection.py 89.65% <0.00%> (+79.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd9a22...e4220e9. Read the comment docs.

dreamerlin
dreamerlin reviewed Nov 10, 2020
View reviewed changes
tests/test_data/test_dataset.py Outdated Show resolved Hide resolved
tests/test_accuracy.py Outdated Show resolved Hide resolved
@dreamerlin dreamerlin added the exist conflict This PR exists conflicts to be resolved label Nov 11, 2020
@kennymckormick
Copy link
Member Author

@innerlee PR ready for merge

@kennymckormick kennymckormick removed the exist conflict This PR exists conflicts to be resolved label Nov 11, 2020
@innerlee innerlee merged commit ebe960b into open-mmlab:master Nov 11, 2020
@dreamerlin dreamerlin linked an issue Nov 15, 2020 that may be closed by this pull request
Improve unittest coverage #301
Closed
8 tasks
@kennymckormick kennymckormick deleted the add_unittest branch November 16, 2020 09:14
@kennymckormick kennymckormick mentioned this pull request Mar 19, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

@dreamerlin dreamerlin Awaiting requested review from dreamerlin

@SuX97 SuX97 Awaiting requested review from SuX97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve unittest coverage
3 participants
@kennymckormick @innerlee @dreamerlin