Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Moses Elleason's speedblog #951

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Add Moses Elleason's speedblog #951

merged 4 commits into from
Jan 29, 2025

Conversation

NPDebs
Copy link
Collaborator

@NPDebs NPDebs commented Jan 25, 2025 •
edited by yochannah
Loading

👍🎉 First of all, thanks for taking the time to contribute! 🎉👍

FOR CONTRIBUTOR

PR Type:

  • This PR adds a new blog post
  • This PR does something else (explain above)

Fixes #949

FOR REVIEWERS

Thanks for taking the time to review! ❤️

Here are the list of things to make sure of:

  • The website builds (a check will fail if not)
  • All images have been added within the Pull Request and they have Alt text
  • If there are paragraphs or text, the key messages are highlighted
  • All internal links (within OLS website) use the {% link path_to_file.md %} format
  • The preview corresponds to the changes described in the Pull Request
  • The code is tidy and passes the linting tests

@netlify Netlify
Copy link

netlify bot commented Jan 25, 2025 •
edited
Loading

✅ Deploy Preview for ols-bebatut ready!

Name Link
🔨 Latest commit f520e14
🔍 Latest deploy log https://app.netlify.com/sites/ols-bebatut/deploys/679a03410151de0008e23c3a
😎 Deploy Preview https://deploy-preview-951--ols-bebatut.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yochannah
yochannah reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@yochannah yochannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debs - could you please add a short intro mentioning this is a speddblog from OLS-9? Thx.

yochannah
yochannah requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@yochannah yochannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also want a new header image
screenshot showing two different blog posts with the same header image

@NPDebs
Copy link
Collaborator Author

NPDebs commented Jan 27, 2025

We'll also want a new header image

Definitely, yeah! That's a placeholder while I let @Melleason pick whatever image they prefer.

Moses, do you have something in mind yet?
I find a lot of inspiration here: http://unsplash.com/

@yochannah
Copy link
Member

yochannah commented Jan 27, 2025 via email

@NPDebs NPDebs marked this pull request as draft January 27, 2025 12:47
Melleason
Melleason reviewed Jan 27, 2025
View reviewed changes
Copy link

@Melleason Melleason left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

Line 14 "Caribou are" to be replaced by " The caribou is"
Line 33 bullet to be corrected
Line 44 to be consistent with line 48 hence a paragraph required

Please find below an updated version for your consideration

Review_SpeedBlog_2025-01-25-translating-caribou-habitat-modelling-with-indigenous-insights.md

@Melleason
Copy link

We'll also want a new header image

Definitely, yeah! That's a placeholder while I let @Melleason pick whatever image they prefer.

Moses, do you have something in mind yet? I find a lot of inspiration here: http://unsplash.com/

Not really. However, anything but a somewhat natural environment, landscape, etc. would be great for my case. But if it is a general header image, then I would be glad you decide.

@NPDebs NPDebs marked this pull request as ready for review January 29, 2025 10:17
@NPDebs NPDebs requested review from yochannah and Melleason January 29, 2025 10:18
@NPDebs
Copy link
Collaborator Author

NPDebs commented Jan 29, 2025

@Melleason & @yochannah - Thanks a lot for your feedback! ❤️

I've implemented them and we're all looking pretty good right now -> Deploy preview.

Let me know if you'd like to add or remove anything else. Otherwise, we're good to merge. 🚀

@Melleason
Copy link

@Melleason & @yochannah - Thanks a lot for your feedback! ❤️

I've implemented them and we're all looking pretty good right now -> Deploy preview.

Let me know if you'd like to add or remove anything else. Otherwise, we're good to merge. 🚀

It looks good to me! Thank you.

@yochannah
Copy link
Member

Oh, Moses, those are some GORGEOUS photos! <3

@yochannah yochannah merged commit 3392b83 into open-life-science:main Jan 29, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yochannah yochannah yochannah approved these changes

@Melleason Melleason Awaiting requested review from Melleason

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Blogpost from OLS-9 fellow Moses
3 participants
@NPDebs @yochannah @Melleason