Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use node style events, add initialize #379

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Mar 22, 2023

Adds and initialize handler, and uses node-style event emitters.

@toddbaert toddbaert requested a review from beeme1mr as a code owner March 22, 2023 19:12
@toddbaert toddbaert changed the title Feat/initialize feat! use node style events, add initialize Mar 22, 2023
@toddbaert toddbaert changed the title feat! use node style events, add initialize feat!: use node style events, add initialize Mar 22, 2023
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #379 (e40f3ec) into main (2ff7135) will not change coverage.
The diff coverage is n/a.

❗ Current head e40f3ec differs from pull request most recent head b39dcce. Consider uploading reports for the commit b39dcce to get more accurate results

@@           Coverage Diff           @@
##             main     #379   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          18       18           
  Lines        1326     1326           
  Branches      101      101           
=======================================
  Hits         1324     1324           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert toddbaert merged commit 6625918 into main Mar 22, 2023
toddbaert pushed a commit that referenced this pull request Mar 22, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.2.0-experimental](web-sdk-v0.1.0-experimental...web-sdk-v0.2.0-experimental)
(2023-03-22)


### ⚠ BREAKING CHANGES

* use node style events, add initialize
([#379](#379))

### Features

* use node style events, add initialize
([#379](#379))
([6625918](6625918))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lukas-reining pushed a commit that referenced this pull request Jun 29, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants