Support passing a %Reference{} as a response when doing controller specs #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorbash
reviewed
Apr 7, 2023
| @@ -27,6 +27,7 @@ defmodule OpenApiSpexTest.UserControllerAnnotated do | |||
| }, | |||
| unauthorized: Unauthorized.response(), | |||
| not_found: NotFound.response(), | |||
| unprocessable_entity: %Reference{"$ref": "#/components/responses/unprocessable_entity"}, | |||
There was a problem hiding this comment.
Is the referenced response defined? In the tests we should show how such references are mean to be used.
zorbash
reviewed
Apr 7, 2023
| @@ -27,6 +27,7 @@ defmodule OpenApiSpexTest.UserControllerAnnotated do | |||
| }, | |||
| unauthorized: Unauthorized.response(), | |||
| not_found: NotFound.response(), | |||
| unprocessable_entity: %Reference{"$ref": "#/components/responses/unprocessable_entity"}, | |||
There was a problem hiding this comment.
Let's also update examples/phoenix_app showing how this can be used.
There was a problem hiding this comment.
Does this work? a3824e4
|
Hey @zorbash is anything holding this off? |
I tested this locally in some of my apps and seems to be working without issues. |
zorbash
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #530