Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of Poison with Jason in tests and examples #104

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Replace usage of Poison with Jason in tests and examples #104

merged 1 commit into from
Apr 21, 2019

Conversation

mbuhot
Copy link
Collaborator

@mbuhot mbuhot commented Apr 21, 2019

Both are supported, but Jason is the default for new phoenix projects,
so examples are updated to reflect the common usage.

@mbuhot
Replace usage of Poison with Jason in tests and examples
4f847dc 
Both are supported, but Jason is the default for new phoenix projects,
so examples are updated to reflect the common usage.
@mbuhot mbuhot requested a review from fenollp April 21, 2019 10:44
fenollp
fenollp approved these changes Apr 21, 2019
View reviewed changes
Copy link
Contributor

@fenollp fenollp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fenollp fenollp merged commit 709bb0b into master Apr 21, 2019
@fenollp fenollp deleted the use-jason-encoders branch April 21, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenollp fenollp fenollp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbuhot @fenollp