Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc changes #324

Merged
merged 2 commits into from
Aug 20, 2024
Merged

misc changes #324

merged 2 commits into from
Aug 20, 2024

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Aug 20, 2024

Description

  • update_manifest.sh: support specifying image tag through env variable NEWTAG
  • helm chatqna-ui: rename chart name to chagqna-ui

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

n/a.

Tests

Describe the tests that you ran to verify your changes.

@lianhao lianhao added this to the v0.9 milestone Aug 20, 2024
Support specify image version by env variable NEWTAG

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Copy link
Contributor

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daisy-ycguo daisy-ycguo merged commit b1182c4 into opea-project:main Aug 20, 2024
10 checks passed
@lianhao lianhao deleted the release_bot branch August 21, 2024 00:10
chensuyue pushed a commit that referenced this pull request Aug 21, 2024
* update_manifest.sh: Support specify image version
* Rename chatqna-ui helm chart name to chatqna-ui

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
(cherry picked from commit b1182c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants