Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stream issue. #1120

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix stream issue. #1120

merged 2 commits into from
Jan 8, 2025

Conversation

lkk12014402
Copy link
Collaborator

@lkk12014402 lkk12014402 commented Jan 7, 2025 •
edited
Loading

Description

Although openai chat completion request use stream as input, we need pass streaming field when we use from langchain_openai import ChatOpenAI or rom langchain_huggingface import HuggingFaceEndpoint

fix the issue caused by this #1098

@lkk12014402 lkk12014402 requested a review from XinyaoWa January 7, 2025 11:29
@chensuyue chensuyue merged commit 650be0d into main Jan 8, 2025
15 checks passed
@chensuyue chensuyue deleted the fix_agent_stream branch January 8, 2025 02:40
@yongfengdu yongfengdu mentioned this pull request Jan 15, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XinyaoWa XinyaoWa XinyaoWa approved these changes

@minmin-intel minmin-intel minmin-intel approved these changes

@lvliang-intel lvliang-intel Awaiting requested review from lvliang-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lkk12014402 @minmin-intel @XinyaoWa @chensuyue