Add tenant context #2596
Merged
Add tenant context #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
changed the base branch from
main
to
tenant_provisioning_dataplane
yuhongsun96
approved these changes
Oct 3, 2024
| "task": "check_for_vespa_sync_task", | ||
| "schedule": timedelta(seconds=5), | ||
| "options": {"priority": DanswerCeleryPriority.HIGH}, | ||
| "args": (tenant_id,), |
There was a problem hiding this comment.
What is the upside/downside of doing this per tenant vs iterating over the tenants in the actual task?
| @@ -392,13 +405,35 @@ def kickoff_indexing_jobs( | |||
| return existing_jobs_copy | |||
|
|
|||
|
|
|||
| def get_all_tenant_ids() -> list[str] | list[None]: | |||
There was a problem hiding this comment.
Should we add some prefix for the tenants to double check they're danswer tenants? In case there is other stuff in the DB (which there probably shouldn't be it's better to be safe).
pablonyx
force-pushed
the
tenant_provisioning_dataplane
branch
2 times, most recently
from
6a7250d to
b579648
Compare
pablonyx
force-pushed
the
tenant_context_background
branch
from
2247ed3 to
8e92aed
Compare
pablonyx
force-pushed
the
tenant_context_background
branch
from
0cbb679 to
e3424e1
Compare
pablonyx
force-pushed
the
tenant_context_background
branch
from
da194ae to
90331bd
Compare
pablonyx
force-pushed
the
tenant_context_background
branch
from
bc41ccd to
e9043ef
Compare
pablonyx
force-pushed
the
tenant_context_background
branch
from
d52a499 to
a4dad03
Compare
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial addition of tenant context to background processing/tasks