Allow setting QA_TIMEOUT from env var #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@james-choncholas is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
DISABLE_AUTH should make the oauth setting irrelevant. If someone wants to turn on auth, they would need oauth on anyway currently. So let's not require the extra setting change. The default is to have oauth on
yuhongsun96
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to increase the timeout is useful when overriding OPENAI_API_BASE to point to a self hosted model e.g. llama-cpp-python's integrated "web sever" e.g. self-hosted openai-like api.
This PR also adds a default for the missing env var "ENABLE_OAUTH" which was preventing startup when using docker compose.