Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Sites.Selected permissions to the SharePoint Connector and enabled the selection of individual subfolders #1583

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Added support for Sites.Selected permissions to the SharePoint Connector and enabled the selection of individual subfolders #1583

merged 1 commit into from
Jun 7, 2024

Conversation

nsklei
Copy link
Contributor

@nsklei nsklei commented Jun 7, 2024

This commit enhances the SharePoint Connector with the following features:

  1. Support for Sites.Selected Permissions:

    • Enables granular access control by supporting Sites.Selected permissions.
    • The existing method using Sites.Read.All permissions remains unchanged and fully functional.
    • Allows administrators to specify certain SharePoint sites which enhances security and compliance with organizational policies.

  2. Subfolder Selection Capability:

    • Adds functionality to select individual subfolders within a SharePoint site.
    • Provides users with more precise data management options.

@nsklei
Added support for Sites.Selected permissions to the SharePoint Connec…
83ff72c 
…tor and enabled the selection of individual subfolders
@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024

@nsklei is attempting to deploy a commit to the Danswer Team on Vercel.

A member of the Team first needs to authorize it.

@hagen-danswer hagen-danswer mentioned this pull request Jun 7, 2024
Closed
yuhongsun96
yuhongsun96 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We tested it all on our end and it works like a charm!

@yuhongsun96 yuhongsun96 merged commit 7a3c102 into onyx-dot-app:main Jun 7, 2024
1 check failed
@nsklei nsklei deleted the sharepoint-sites-selected branch June 8, 2024 08:35
@onimsha onimsha mentioned this pull request Jun 9, 2024
Merged
vanabharathiraja pushed a commit to sernddev/docudive that referenced this pull request Nov 28, 2024
@nsklei
Added support for Sites.Selected permissions to the SharePoint Connec…
94c72db 
…tor and enabled the selection of individual subfolders (onyx-dot-app#1583)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhongsun96 yuhongsun96 yuhongsun96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsklei @yuhongsun96