-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making runtime omunreachable static to support clang compiler #3015
Making runtime omunreachable static to support clang compiler #3015
Conversation
Signed-off-by: Christopher Munoz <chrismunoz1019@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Jenkins Linux s390x Build #16024 [push] making runtime omunreach... started at 10:06 |
Jenkins Linux amd64 Build #16021 [push] making runtime omunreach... started at 09:06 |
Jenkins Linux ppc64le Build #15051 [push] making runtime omunreach... started at 10:21 |
Jenkins Linux s390x Build #16024 [push] making runtime omunreach... failed after 1 hr 1 min |
Jenkins Linux amd64 Build #16021 [push] making runtime omunreach... passed after 1 hr 18 min |
Jenkins Linux ppc64le Build #15051 [push] making runtime omunreach... passed after 2 hr 20 min |
Compiling and linking runtime files on zOS using ibm-clang compiler will error.
Following suggestions "In C99 you need to provide an alternate (non-inline) definition of the function for when the compiler can't inline."
https://stackoverflow.com/questions/69384040/why-do-i-get-a-linking-error-with-clang-when-inlining-a-function-in-a-c-program
I am open to trying alternative methods to support clang compilers if there are other suggestions.