Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming Groq changes #1703

Closed
7 of 11 tasks
philass opened this issue Sep 17, 2022 · 5 comments
Closed
7 of 11 tasks

Upstreaming Groq changes #1703

philass opened this issue Sep 17, 2022 · 5 comments

Comments

@philass
Copy link
Member

philass commented Sep 17, 2022

We have been working with onnx-mlir for years now at Groq. As a result we have added some additional features, bug fixes, and have some general divergence.

Time permitting could we discuss a strategy for us upstreaming our changes in the onnx-mlir Tuesday meeting.

Below is hopefully a comprehensive list of what we have

We see big benefits in minimizing our divergence from upstream. I'm actively working to upstream these changes. I want to make sure that we do it in a way that doesn't overwhelm.

@AlexandreEichenberger
Copy link
Collaborator

That would be great! We already have a presentation for this Tu, would next week work?

@philass
Copy link
Member Author

philass commented Sep 19, 2022

Yes next week would work well too

@AlexandreEichenberger
Copy link
Collaborator

AlexandreEichenberger commented Sep 20, 2022

Added on wiki meeting page. If you have a presentation deck, please add it here when available.

@philass
Copy link
Member Author

philass commented Oct 11, 2022

We are making really good progress on this

Only two PRs remaining:

@philass
Copy link
Member Author

philass commented Oct 11, 2022

Actually there are two more after those

But that is it!

@philass philass closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants