Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Promote ignore_index in NegativeLogLikelihoodLoss-13 to input #4993

Open
justinchuby opened this issue Mar 14, 2023 · 2 comments
Open

[Feature request] Promote ignore_index in NegativeLogLikelihoodLoss-13 to input #4993

justinchuby opened this issue Mar 14, 2023 · 2 comments
Labels
contributions welcome enhancement Request for new feature or operator operator Issues related to ONNX operators stale
Milestone
Future

Comments

@justinchuby
Copy link
Contributor

justinchuby commented Mar 14, 2023 •
edited by jcwchen
Loading

System information

No response

What is the problem that this feature solves?

In PyTorch, ignore_index is dynamic: nll_loss(Tensor self, Tensor target, Tensor? weight=None, int reduction=Mean, SymInt ignore_index=-100) -> Tensor. To fully support this op, we can promote ignore_index in NegativeLogLikelihoodLoss-13 to input.

cc @gramalingam

Alternatives considered

No response

Describe the feature

No response

Will this influence the current api (Y/N)?

No response

Feature Area

No response

Are you willing to contribute it (Y/N)

None

Notes

No response
@justinchuby justinchuby added the enhancement Request for new feature or operator label Mar 14, 2023
@justinchuby justinchuby mentioned this issue Mar 14, 2023
Closed
@titaiwangms
Copy link

cc @gramalingam

@gramalingam
Copy link
Contributor

Yes, it sounds reasonable to do this. I believe onnxruntime uses custom ops for this reason (see here), We should consider using that extension as a candidate and propose a PR.

@justinchuby justinchuby added this to the 1.16 milestone Aug 26, 2023
@justinchuby justinchuby added operator Issues related to ONNX operators contributions welcome labels Aug 26, 2023
@justinchuby justinchuby modified the milestones: 1.16, Future Dec 22, 2023
@github-actions github-actions bot added the stale label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome enhancement Request for new feature or operator operator Issues related to ONNX operators stale
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@gramalingam @justinchuby @titaiwangms