update the default branch to main #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenbing Li <wenbingl@outlook.com>
jcwchen
reviewed
Feb 9, 2022
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -115,7 +115,7 @@ ort_test_dir_utils.create_test_dir(model_path, 'temp/examples', 'test2', name_in | |||
| ``` | |||
|
|
|||
| ### More details | |||
| https://github.com/microsoft/onnxruntime/blob/master/tools/python/PythonTools.md | |||
| https://github.com/microsoft/onnxruntime/blob/main/tools/python/PythonTools.md | |||
There was a problem hiding this comment.
Suggested change
| https://github.com/microsoft/onnxruntime/blob/main/tools/python/PythonTools.md | |
| https://github.com/microsoft/onnxruntime/blob/master/tools/python/PythonTools.md |
onnxruntime is still using master today. I think only onnx/onnx and onnx/models need to be updated to main. Other repo links changed by this PR need to be checked whether they use main branch. Otherwise, the links will be broken.
There was a problem hiding this comment.
Thanks for the reminder, only update the links in onnx/model project now.
@jcwchen , do you still keep the master branch in onnx/onnx repo since the external projects may still have the link to master branch?
There was a problem hiding this comment.
I didn't keep it. According to here, the old link with master should be still workable. I don't know how long it will last though.
This reverts commit 492d3b1. Signed-off-by: Wenbing Li <wenbingl@outlook.com>
Signed-off-by: Wenbing Li <wenbingl@outlook.com>
Signed-off-by: Wenbing Li <wenbingl@outlook.com>
jcwchen
approved these changes
Feb 10, 2022
This was referenced Mar 15, 2022
jcwchen
pushed a commit
to jcwchen/models
that referenced
this pull request
Apr 26, 2022
* update the default branch to main Signed-off-by: Wenbing Li <wenbingl@outlook.com> * Revert "update the default branch to main" This reverts commit 492d3b1. Signed-off-by: Wenbing Li <wenbingl@outlook.com> * only keep renaming for onnx/onnx onnx/models Signed-off-by: Wenbing Li <wenbingl@outlook.com> * update the branch in ci Signed-off-by: Wenbing Li <wenbingl@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search and replace all the text with 'master' name,
then set the main branch be default after the PR is merged.