Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoogLenet Pre and post process #333

Merged
merged 5 commits into from
Jul 23, 2020
Merged

GoogLenet Pre and post process #333

merged 5 commits into from
Jul 23, 2020

Conversation

M-Tonin
Copy link
Contributor

@M-Tonin M-Tonin commented Jul 18, 2020

Model Name

GoogLenet - update of readme, adding pre and post process

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@prasanthpul prasanthpul requested a review from vinitra-zz July 21, 2020 18:05
vinitra-zz
vinitra-zz reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@vinitra-zz vinitra-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Fixing preprocessing and postprocessing steps are really important.

vision/classification/inception_and_googlenet/googlenet/README.md Outdated Show resolved Hide resolved
vision/classification/inception_and_googlenet/googlenet/README.md Outdated Show resolved Hide resolved
vision/classification/inception_and_googlenet/googlenet/README.md Outdated Show resolved Hide resolved
vision/classification/inception_and_googlenet/googlenet/README.md Outdated Show resolved Hide resolved
vinitra-zz
vinitra-zz approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@vinitra-zz vinitra-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Made a few minor grammatical changes. Thank you.

@vinitra-zz vinitra-zz merged commit 16ab8f8 into onnx:master Jul 23, 2020
@vinitra-zz vinitra-zz mentioned this pull request Jul 23, 2020
Open
@vinitra-zz vinitra-zz linked an issue Jul 23, 2020 that may be closed by this pull request
Missing pre process and post process #332
Open
jcwchen pushed a commit to jcwchen/models that referenced this pull request Apr 26, 2022
@M-Tonin
GoogLenet Pre and post process (onnx#333)
b5ab0b8 
* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitra-zz vinitra-zz vinitra-zz approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing pre process and post process
4 participants
@M-Tonin @CLAassistant @vinitra-zz @vinitra