add rotation-ordering util #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to transform some BVH files, There was a problem that the positions of joints are located very strangely.
Now I find the reason, there is a problem in 'rotation_tools.py'
The problem is that you only considered about BVH file that have 'XYZ-order' in rotation channel.
Actually, there are BVH file that have 'ZYX-order' or 'ZXY-order' or etc... too.
As you know, in rotation matrix, the joining order of single-axis rotation matrix is very important(commutative law is not valid).
So, I just add one parameter named 'rotation_order' at class 'Rotation', and add a simple 'For Clause' at 'rotation_tools.py' to make a correct order.
And, to give argument to 'Rotation', I modify 'preprocessin.py' very a little bit.
I wish your 'PyMO' contributing to more people.
Thank you for sharing good open-source.
-demul