Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add peer dep pact-js v11 and nest-js v10 #47

Merged
merged 3 commits into from
Jul 10, 2023
Merged

fix: add peer dep pact-js v11 and nest-js v10 #47

merged 3 commits into from
Jul 10, 2023

Conversation

JoffrayBillon
Copy link
Contributor

Add Nest 10 and Pact 11 support

Description

As there is no impacting changes with the Nest 10 and Pact 11 releases for this package change the peerDependencies, to allow nest 10 to be used as a peer dependancy.
Also changed the fixed v10 pact version to any v10 and v11 (ok for v11 as I said before)

Motivation and Context

Make the package work for NestJS recent release 10 on npm install without error Conflicting peer dependency.

How Has This Been Tested?

In my fork branch of the nestjs-pact project:

npm run build
npm pack --pack-destination ~

Then in the "final project" I try npm install after replacing in the package.json:

"nestjs-pact": "^2.3.0",

With

"nestjs-pact": "file:~/nestjs-pact-2.3.1.tgz",

Check if installation pass, looks good, good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JoffrayBillon JoffrayBillon mentioned this pull request Jul 6, 2023
Closed
@YOU54F
Copy link
Member

YOU54F commented Jul 7, 2023 •
edited
Loading

Thanks for the PR, it is very odd that it triggered the workflows automatically however, as our settings as meant to prevent that for first time contributors

Screenshot 2023-07-07 at 10 32 00 Screenshot 2023-07-07 at 10 32 42

@YOU54F
Copy link
Member

YOU54F commented Jul 7, 2023

Oh I can see Matt triggered it :) Will take a look at the errors today

@YOU54F YOU54F mentioned this pull request Jul 7, 2023
Closed
@YOU54F
Copy link
Member

YOU54F commented Jul 7, 2023

Hey, if you could update the commit messages, to follow the commit convention as suggested by the latest error message. we will get a green build 👍🏾

fix: add peer dep pact-js v11 and nest-js v10

@YOU54F
Copy link
Member

YOU54F commented Jul 7, 2023

I'll leave this with you so you can get attribution rather than merging the draft PR I created for testing. Cheers buddy

@JoffrayBillon JoffrayBillon changed the title Add Nest 10 and Pact 11 support fix: add peer dep pact-js v11 and nest-js v10 Jul 10, 2023
@JoffrayBillon
Copy link
Contributor Author

It's done all messages renamed according the convention.

@YOU54F YOU54F merged commit d90cc37 into pact-foundation:master Jul 10, 2023
github-actions bot pushed a commit that referenced this pull request Jul 10, 2023
@semantic-release-bot
chore(release): 2.3.1 [skip ci]
2536a13 
## [2.3.1](v2.3.0...v2.3.1) (2023-07-10)

### Bug Fixes

* add peer dep pact-js v11 and nest-js v10 ([#47](#47)) ([d90cc37](d90cc37))
@github-actions
Copy link

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@YOU54F YOU54F linked an issue Jul 10, 2023 that may be closed by this pull request
Add support for nest 10 #46
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for nest 10
2 participants
@JoffrayBillon @YOU54F