Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fly example #951

Merged
merged 2 commits into from
May 7, 2024
Merged

fly example #951

merged 2 commits into from
May 7, 2024

Conversation

mxyng
Copy link
Contributor

@mxyng mxyng commented Oct 30, 2023

No description provided.

BruceMacD
BruceMacD reviewed Oct 30, 2023
View reviewed changes
examples/deploy-fly/README.md Outdated Show resolved Hide resolved
examples/deploy-fly/README.md Outdated Show resolved Hide resolved
@mxyng mxyng force-pushed the mxyng/example-fly branch 6 times, most recently from 82d9703 to 548664b Compare October 30, 2023 19:36
technovangelist
technovangelist reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@technovangelist technovangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there isn't an example here, just instructions on how to create the example. Can you create the toml file to make it easier to run. it can be opinionated.

@mxyng mxyng force-pushed the mxyng/example-fly branch 2 times, most recently from 2bd3c6b to b9a1174 Compare November 1, 2023 21:57
@mxyng mxyng force-pushed the mxyng/example-fly branch from b9a1174 to b99c291 Compare November 1, 2023 21:58
@mxyng
Copy link
Contributor Author

mxyng commented Nov 1, 2023

there isn't an example here, just instructions on how to create the example

I don't see a distinction. Adding a sample toml file has marginal benefits while also being inflexible.

@jmorganca
Copy link
Member

This looks good, I think what might be missing is the fly.toml file unless that's custom per-user?

jmorganca
jmorganca reviewed May 6, 2024
View reviewed changes
examples/flyio/README.md Outdated Show resolved Hide resolved
@mxyng @jmorganca
Update examples/flyio/README.md
3f0ed03 
Co-authored-by: Jeffrey Morgan <jmorganca@gmail.com>
@mxyng mxyng merged commit d7d33e5 into main May 7, 2024
12 checks passed
@mxyng mxyng deleted the mxyng/example-fly branch May 7, 2024 17:46
@charsleysa
Copy link

charsleysa commented May 9, 2024 •
edited
Loading

@mxyng this example is no longer correct regarding GPUs, see #1406 for an up-to-date example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD left review comments

@technovangelist technovangelist technovangelist left review comments

@jmorganca jmorganca jmorganca left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mxyng @jmorganca @charsleysa @technovangelist @BruceMacD