examples: remove codified examples #8267
Conversation
There was a problem hiding this comment.
Would it be worth keeping this in the api package? e.g. api/examples? I don't think it's a must-have but is handy for anyone using that code (and perhaps we could move it in a follow up?)
There was a problem hiding this comment.
I actually think we shouldn't have go examples since we don't officially support this + can be an unstable interface so I'm a bit hesitant to have this in there. I think curl examples as what we have in our docs is the way to go but happy to chat
There was a problem hiding this comment.
It's an exposed package and these are generally nice and simple. For this PR, I think what makes sense is to keep them under api/examples with better directory names (but definitely not top level), and if, similar to the other examples we find them falling behind we can remove them in a follow up.
There was a problem hiding this comment.
Okay, let me move it to under there for now and then also do some sanity checks to make sure they're up to date. I do think we should talk about what level API consistencies we should guarantee if we're having that in examples
ParthSareen
force-pushed
the
parth/remove-examples
branch
from
c804715 to
05e0aba
Compare
| @@ -12,3 +12,9 @@ Ollama JavaScript examples at [ollama-js/examples](https://github.com/ollama/oll | |||
|
|
|||
| ## OpenAI compatibility examples | |||
| Ollama OpenAI compatibility examples at [ollama/examples/openai](../docs/openai.md) | |||
|
|
|||
There was a problem hiding this comment.
Do we want to just remove this directory altogether?
There was a problem hiding this comment.
Hmm I think people usually look for some reference to examples. I'd be okay with moving this readme to examples.md what do you think?
This PR aims to streamline the examples and to have outgoing links to community frameworks instead.
Closes #8117