Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Docker image as non-root #504

Merged
merged 4 commits into from
Mar 22, 2021
Merged

Run Docker image as non-root #504

merged 4 commits into from
Mar 22, 2021

Conversation

eumel8
Copy link
Contributor

@eumel8 eumel8 commented Mar 19, 2021

I'v struggled with some issue to get the exporter running by the Helm chart. Pod Security Policy was created but enforced AppArmor profile will prefent the POD start:

Status:         Pending
Reason:         AppArmor
Message:        Cannot enforce AppArmor: AppArmor is not enabled on the host

The default PSP on my cluster doesn't allow to run root images. Normaly the is a USER defintion in the Dockerfile which is here only in the builder, but not the finally image. Added the USER definition there and got the exporter running.

@coveralls
Copy link

coveralls commented Mar 19, 2021

Pull Request Test Coverage Report for Build 1115

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 91.485%

Files with Coverage Reduction New Missed Lines %
exporter/info.go 3 97.48%
Totals Coverage Status
Change from base Build 1101: 0.6%
Covered Lines: 1429
Relevant Lines: 1562

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #504 (9e5997d) into master (d0597c8) will increase coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   86.51%   87.20%   +0.68%     
==========================================
  Files          15       15              
  Lines        1261     1266       +5     
==========================================
+ Hits         1091     1104      +13     
+ Misses        100       96       -4     
+ Partials       70       66       -4     
Impacted Files Coverage Δ
exporter/latency.go 100.00% <0.00%> (ø)
exporter/info.go 96.23% <0.00%> (+4.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0597c8...9e5997d. Read the comment docs.

@oliver006
Copy link
Owner

Thanks for the PR, this is great!
Can you add this to the two ARM docker files as well? Thanks!

@eumel8
Copy link
Contributor Author

eumel8 commented Mar 22, 2021

@oliver006 done

Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@oliver006 oliver006 merged commit f367ed4 into oliver006:master Mar 22, 2021
@oliver006
Copy link
Owner

Released as v1.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants