Fix drone docker releases #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Post merging of oliver006#435, drone docker releases are broken. This commit fixes it.
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
+ Coverage 75.28% 84.12% +8.83%
==========================================
Files 2 1 -1
Lines 1133 1077 -56
==========================================
+ Hits 853 906 +53
+ Misses 215 101 -114
- Partials 65 70 +5
Continue to review full report at Codecov.
|
|
Thanks for the quick fix! |
|
Note to self: I should a dry-run docker build to the tests so this won't happen again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post merging of #435, drone docker releases are broken. Check https://cloud.drone.io/oliver006/redis_exporter/922/1/13 for reference.
This commit fixes it.