fix: Respect translation overrides for errors.E0xxx in i18n of widget config
#3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
changed the title
errors.E00xxx errors.E0xxx
denysoblohin-okta
changed the title
errors.E0xxx errors.E0xxx in i18n of widget config
denysoblohin-okta
force-pushed
the
od-fix-error-loc-OKTA-819400
branch
from
d385977 to
dce46e3
Compare
jaredperreault-okta
approved these changes
Nov 5, 2024
denysoblohin-okta
requested review from
nikhilvenkatraman-okta,
mauriciocastillosilva-okta,
zihanwang-okta,
michaeltamaki-okta,
sherizada-okta and
aarongranick-okta
as code owners
shuowu-okta
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue introduced in #3579
In that PR error message for code
E0000068stoped to being localized (because there is no localization for it in default translation files bundled with SIW) and started to be taken fromerrorSummaryin Authn API response.But customer should be allowed to add translation overrides for any error codes in
i18nof widget config.PR Checklist
Issue:
Reviewers:
Screenshot/Video:
loc-fix.mov
Downstream Monolith Build: