fix: the shell option value should be optional instead of required #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug introduced in #994 where any text after the `--shell` option was interpreted as its value, for example in `--shell --relative` the value was `"--relative"` instead of implied `true`.
|
Ping @okonet I messed up the configuration of Commander a bit. |
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 633 633
Branches 148 148
=========================================
Hits 633 633 Continue to review full report at Codecov.
|
okonet
approved these changes
Jul 24, 2021
|
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #994 where any text after the
--shelloption was interpreted as its value, for example in--shell --relativethe value was"--relative"instead of impliedtrue.