Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output when no files match #135

Closed
Noirbot opened this issue Mar 7, 2017 · 3 comments
Closed

Add output when no files match #135

Noirbot opened this issue Mar 7, 2017 · 3 comments

Comments

@Noirbot
Copy link
Contributor

Noirbot commented Mar 7, 2017

It would be helpful to have some sort of output if I run lint-staged, but it finds no files that have matching linters. Right now, I just see something like

> lint-staged

Which doesn't really tell me anything about what happened, and leaves me wondering if it did anything at all.

Perhaps something like:

> lint-staged

✔ No files staged matching *.{js,jsx}

For each linter pattern.
@okonet
Copy link
Collaborator

okonet commented Mar 7, 2017

It's actually by design since I didn't want to generate noise in the CLI but I can see how this can be helpful though. I wouldn't mind a PR for this I guess.

@Noirbot
Copy link
Contributor Author

Noirbot commented Mar 7, 2017

We could even do something more minimal than what I proposed - It would just be helpful to have some indication that lint-staged actually ran. I'll see about making a PR.

@okonet
Copy link
Collaborator

okonet commented Mar 7, 2017

Yeah, propose a better solution and I'll consider it :)

@Noirbot Noirbot mentioned this issue Mar 13, 2017
Merged
@okonet okonet closed this as completed in b0204ee Mar 13, 2017
@dan-gamble dan-gamble mentioned this issue Mar 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okonet @Noirbot