-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: react-native/metro bundler ignored warning of subpath package.json #1059
fix: react-native/metro bundler ignored warning of subpath package.json #1059
Conversation
@nomi9995 can you explain what this means? |
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 653 653
Branches 173 173
=========================================
Hits 653 653 Continue to review full report at Codecov.
|
@iiroj |
After reading the original issue, I don't see how this is relevant for lint-staged. Can you explain please why this needs to be fixed here? |
@okonet actually metro bundler needs to access package.json for export packages. when we install this library into |
But why would you want to export anything related to lint-staged to production? This package is meant to be used as a devDependency only. I still don't understand the problem you're trying to solve. |
@okonet actually I don't know why metro bundler is importing package.json of export packages |
6acaed1
to
cf1cebb
Compare
🎉 This PR is included in version 12.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Cannot run lint-staged on yarn berry when pnpEnableEsmLoader is false |
fixed react-native-community/cli#1168