Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes jump plugin printf path output #7105

Merged
merged 2 commits into from
Sep 1, 2018

Conversation

rlafferty
Copy link
Contributor

@rlafferty rlafferty commented Aug 31, 2018

Using the jump plugin, using the marks command will yield this output:

$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->

the marks function uses printf with -> and I believe - is used by printf for left-justification. changing this to -- "->" seems to render the appropriate output.

desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname

@mcornella
Copy link
Member

We can use -- to stop the parsing of hyphen options, like so: printf -- ->....

This way we keep the same format while fixing the errors.

@rlafferty
Copy link
Contributor Author

@mcornella - good idea! Updated.

@mcornella mcornella merged commit 0853b74 into ohmyzsh:master Sep 1, 2018
@mcornella
Copy link
Member

Thanks!

gerardo pushed a commit to gerardo/oh-my-zsh that referenced this pull request Sep 3, 2018
* 'master' of https://github.com/robbyrussell/oh-my-zsh: (181 commits)
  jump: fix printf path output (ohmyzsh#7105)
  vi-mode: reset-prompt if zle is active (TRAPWINCH)
  fix nmap vuln category name (ohmyzsh#7044)
  Update kubectl.plugin.zsh (ohmyzsh#6636)
  Fix rvm-prompt usage in fino* themes (ohmyzsh#6477)
  vi-mode show indicator on zle-line-init and SIGWINCH (ohmyzsh#6449)
  execute mvnw with "mvn" when mvnw-file is present (ohmyzsh#6484)
  executing gradlew, when gradlew-file exists (ohmyzsh#6485)
  Fixed `fwl` function in `firewalld` plugin when `sources` used (ohmyzsh#7011)
  kubectl: add alias for `kubectl cp` (ohmyzsh#7068)
  Update golang.plugin.zsh (ohmyzsh#6750)
  Update brew.plugin.zsh (ohmyzsh#6947)
  Add aliases for kubectl nodes (ohmyzsh#7093)
  Clarify random theme setting (ohmyzsh#7090)
  [plugins/git] Updated git clone alias (ohmyzsh#6893)
  Updating 'sbcl' to 'sbcln' (ohmyzsh#7095)
  git: add the `git show` alias `gsh` (ohmyzsh#5591)
  nyan: deprecate plugin with removal notice
  github: fix new_gh to force-add .gitignore (ohmyzsh#7086)
  trapd00r: clean up the script
  ...
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Sep 7, 2018
* upstream/master: (225 commits)
  Feat: add Salt completion plugin (ohmyzsh#7031)
  Add fzf plugin (ohmyzsh#6910)
  fasd: use xdg-open in o alias back again
  fasd: drop-in replace the autojump j alias (ohmyzsh#3860)
  jump: fix printf path output (ohmyzsh#7105)
  vi-mode: reset-prompt if zle is active (TRAPWINCH)
  fix nmap vuln category name (ohmyzsh#7044)
  Update kubectl.plugin.zsh (ohmyzsh#6636)
  Fix rvm-prompt usage in fino* themes (ohmyzsh#6477)
  vi-mode show indicator on zle-line-init and SIGWINCH (ohmyzsh#6449)
  execute mvnw with "mvn" when mvnw-file is present (ohmyzsh#6484)
  executing gradlew, when gradlew-file exists (ohmyzsh#6485)
  Fixed `fwl` function in `firewalld` plugin when `sources` used (ohmyzsh#7011)
  kubectl: add alias for `kubectl cp` (ohmyzsh#7068)
  Update golang.plugin.zsh (ohmyzsh#6750)
  Update brew.plugin.zsh (ohmyzsh#6947)
  Add aliases for kubectl nodes (ohmyzsh#7093)
  Clarify random theme setting (ohmyzsh#7090)
  [plugins/git] Updated git clone alias (ohmyzsh#6893)
  Updating 'sbcl' to 'sbcln' (ohmyzsh#7095)
  ...
lellisls pushed a commit to lellisls/oh-my-zsh that referenced this pull request Oct 1, 2018
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
seth-cohen pushed a commit to seth-cohen/oh-my-zsh that referenced this pull request Oct 29, 2018
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
jmartindf pushed a commit to jmartindf/oh-my-zsh that referenced this pull request Nov 10, 2018
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
sagischwarz pushed a commit to sagischwarz/ohmyzsh that referenced this pull request Nov 19, 2018
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
stonetao pushed a commit to stonetao/oh-my-zsh that referenced this pull request Apr 7, 2019
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
chihchun pushed a commit to chihchun/oh-my-zsh that referenced this pull request Aug 6, 2019
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
lewg pushed a commit to lewg/oh-my-zsh that referenced this pull request Nov 25, 2019
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
kankongmeng pushed a commit to kankongmeng/oh-my-zsh that referenced this pull request Jan 8, 2020
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this pull request Jun 17, 2020
Using the `jump` plugin, using the `marks` command will yield this output:
```
$ marks
desktop marks:printf:5: bad option: ->
dotfiles        marks:printf:5: bad option: ->
home    marks:printf:5: bad option: ->
```

the `marks` function uses `printf` with `->` and I believe `-` is used by `printf` for left-justification.  changing this to `-- "->"` seems to render the appropriate output.

```
desktop -> /Users/uname/Desktop
dotfiles        -> /Users/uname/.dotfiles
home    -> /Users/uname
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants