Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using "PREFIX" that cause nvm to complain about. #4572

Merged
merged 1 commit into from
Apr 6, 2016
Merged

Avoid using "PREFIX" that cause nvm to complain about. #4572

merged 1 commit into from
Apr 6, 2016

Conversation

aioutecism
Copy link
Contributor

nvm complains about PREFIX when using sunrise theme:

nvm is not compatible with the "PREFIX" environment variable: currently set to "---"
Run `unset PREFIX` to unset it.

Renaming PREFIX to something else fixed this issue.

@apjanke
Copy link
Contributor

apjanke commented Nov 6, 2015

It looks like that $PREFIX value never changes inside a session, so it can be used just once at prompt setup time. How about instead of changing the name, wrapping stuff in a function and using local to avoid leaking variables, like this?

@apjanke apjanke mentioned this pull request Nov 16, 2015
Closed
@florrain
Copy link

florrain commented Apr 6, 2016

Pushing for this first fix to be merged in. This PR has been opened for 6 months and this is still impacting users (like me 😶)

@mcornella mcornella merged commit d310fac into ohmyzsh:master Apr 6, 2016
@mcornella
Copy link
Member

Thanks for letting me know!

@aioutecism
Copy link
Contributor Author

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aioutecism @apjanke @florrain @mcornella