gnzh theme: fix "eval" and related scope problems. #4113
Conversation
|
👍 /cc @robbyrussell |
|
I tried out this pull request to fix issue #3425 on Debian Jessie. It fixes indeed the eval error message when logging directly into a text console. However, the fix has the side effect that now the arrow part on the second line and the command you enter after it is displayed in bright white (and in KDE Konsole additionally with a thicker font). The start of the arrow on the first line is displayed in the normal gray tone of the text console. |
Switch to normal zsh %F/%f prompt escapes to avoid "eval" and extra variables. Wrap whole thing in anonymous function so the existing `local` statements actually work. Then switch '...' to eager "..." so stuff actually works with local variables. And local-ize the remaining variables that are used only in prompt construction.
|
Looks like an unclosed Some terminals are set to display bold text in a bright color, which is why it looked brighter on your terminal. I didn't notice this while testing because I have the bold=bright setting off in my terminals, and bold doesn't look all that different from normal text to me. But it's clearly visible when toggling the bold font on and off in the profile. I've amended the commit to fix this. Give it another try. |
|
Thank you for your quick reaction to my report! I just tested your fix and now the gnzh theme works nicely without any error messages or coloring problems. 👍 |
|
Great. I think this is ready to merge. |
|
👍 /cc @robbyrussell |
gnzh theme: fix "eval" and related scope problems.
gnzh theme: fix "eval" and related scope problems.
Fixes #3425.
This clears up issues related to
evaland the use of eager vs lazy evaulation in thegnzhtheme. Theevalwas the one causing user-visible problems, but there's a small tangle of related issues, and this addresses them all.The outcome of this PR is that:
%F/%f$PROMPTstring are all eager-evaluated at theme loading time$(...)to call functions at prompt timelocal-izedThis PR removes the problematic
evalusage by switching to normalzsh%F/%f prompt escapes to avoid "eval" and the associated global variables.There were several
localstatements that weren't having any effect, because the theme is not loaded in a function, so they were globals. This PR wraps whole thing in an anonymous function so the existinglocalstatements actually work.But that breaks the theme, because a lot of stuff was done with lazy-evaluated
'...'quotes, which relied on those actually being persistent global variables. So this PR switches '...' to eager "..." where needed, so stuff actually works with local variables.And it
local-izes the remaining variables that are used only in prompt construction.I've tested this on the following, exercising the git, return status, and root detection features, and it looks good.
xterm, andurxvtCould use some more testers for
urxvtand the console on Linux distros that were having this problem, and for RVM.