Skip to content

check_for_upgrade line 24 error on automate shellscript file #9064

Closed
@noghartt

Description

Hey, I'm trying to write a small ShellScript for simple automation of my PC, but I'm having a problem installing oh-my-zsh. I can't interpret if this is a bug or a silly mistake I'm making, could you help me?

sh -c "$(curl -fsSL https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh)" "" --unattended

I'm even using Arch Linux.


Error message
$ $HOME/.oh-my-zsh/tools/check_for_upgrade.sh: line 24: `update_last-updated_file': is not a valid identifier
My ShellScript file
get_value_of()
{
    local VAR_NAME=$1;
    local VAR_VALUE="";

    if set | grep -q "^$VAR_NAME="; then
        eval VAR_VALUE="\$$VAR_NAME"
    fi
    echo "$VAR_VALUE"
}

display_color_text()
{
    local RED=`tput setaf 1`;
    local GREEN=`tput setaf 2`;
    local YELLOW=`tput setaf 3`;
    local BLUE=`tput setaf 4`;

    local RESET_TEXT=`tput sgr0`;

    echo "$(get_value_of $1)$2$RESET_TEXT"
}

######

display_color_text GREEN "Installing ZSH..."
sudo pacman -S zsh

display_color_text GREEN "Installing Oh my ZSH..."
sh -c "$(curl -fsSL https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh)" "" --unattended
source $HOME/.zshrc

display_color_text GREEN "Installing NVM..."
sh -c "$(curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh)"
source $HOME/.zshrc
clear

display_color_text GREEN "Installing Node.js LTS version..."
nvm install --lts
node --version
npm --version
clear
check_for_upgrade.sh file
# Migrate .zsh-update file to $ZSH_CACHE_DIR
if [[ -f ~/.zsh-update && ! -f "${ZSH_CACHE_DIR}/.zsh-update" ]]; then
    mv ~/.zsh-update "${ZSH_CACHE_DIR}/.zsh-update"
fi

# Cancel update if:
# - the automatic update is disabled.
# - the current user doesn't have write permissions nor owns the $ZSH directory.
# - git is unavailable on the system.
if [[ "$DISABLE_AUTO_UPDATE" = true ]] \
   || [[ ! -w "$ZSH" || ! -O "$ZSH" ]] \
   || ! command -v git &>/dev/null; then
    return
fi


function current_epoch() {
    zmodload zsh/datetime
    echo $(( EPOCHSECONDS / 60 / 60 / 24 ))
}

function update_last-updated_file() {
    echo "LAST_EPOCH=$(current_epoch)" >! "${ZSH_CACHE_DIR}/.zsh-update"
}

function update_ohmyzsh() {
    ZSH="$ZSH" sh "$ZSH/tools/upgrade.sh"
    update_last-updated_file
}

() {
    emulate -L zsh

    local epoch_target mtime option LAST_EPOCH

    # Remove lock directory if older than a day
    zmodload zsh/datetime
    zmodload -F zsh/stat b:zstat
    if mtime=$(zstat +mtime "$ZSH/log/update.lock" 2>/dev/null); then
        if (( (mtime + 3600 * 24) < EPOCHSECONDS )); then
            command rm -rf "$ZSH/log/update.lock"
        fi
    fi

    # Check for lock directory
    if ! command mkdir "$ZSH/log/update.lock" 2>/dev/null; then
        return
    fi

    # Remove lock directory on exit. `return 1` is important for when trapping a SIGINT:
    #  The return status from the function is handled specially. If it is zero, the signal is
    #  assumed to have been handled, and execution continues normally. Otherwise, the shell
    #  will behave as interrupted except that the return status of the trap is retained.
    trap "rm -rf '$ZSH/log/update.lock'; return 1" EXIT INT QUIT

    # Create or update .zsh-update file if missing or malformed
    if ! source "${ZSH_CACHE_DIR}/.zsh-update" 2>/dev/null || [[ -z "$LAST_EPOCH" ]]; then
        update_last-updated_file
        return
    fi

    # Number of days before trying to update again
    epoch_target=${UPDATE_ZSH_DAYS:-13}
    # Test if enough time has passed until the next update
    if (( ( $(current_epoch) - $LAST_EPOCH ) < $epoch_target )); then
        return
    fi

    # Ask for confirmation before updating unless disabled
    if [[ "$DISABLE_UPDATE_PROMPT" = true ]]; then
        update_ohmyzsh
    else
        # input sink to swallow all characters typed before the prompt
        # and add a newline if there wasn't one after characters typed
        while read -t -k 1 option; do true; done
        [[ "$option" != ($'\n'|"") ]] && echo

        echo -n "[oh-my-zsh] Would you like to update? [Y/n] "
        read -r -k 1 option
        [[ "$option" != $'\n' ]] && echo
        case "$option" in
            [nN]) update_last-updated_file ;;
            *) update_ohmyzsh ;;
        esac
    fi
}

unset -f current_epoch update_last-updated_file update_ohmyzsh

Metadata

Assignees

No one assigned

    Labels

    Area: updaterUpdate subsystemBugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions