Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple improvements over key binding logic #11

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

simonrouse9461
Copy link
Contributor

  • Dynamically reset key bindings when $fish_key_bindings changes

  • Add support for fish_hybrid_key_bindings mode

  • Fix the bug that end-of-line $ is overridden by the plugin in fish vim/hybrid command mode

* Dynamically reset key bindings when `$fish_key_bindings` changes

* Add support for `fish_hybrid_key_bindings` mode

* Fix the bug that end-of-line `$` does not work in fish vim command mode
@simonrouse9461
Copy link
Contributor Author

simonrouse9461 commented Nov 24, 2022

@bobthecow @williamhogman @unusedPhD @bpinto Can someone take a look at the PR, please? I really appreciate it!

@derekstavis
Copy link
Member

Appreciate it!

@derekstavis derekstavis merged commit 7d93e8a into oh-my-fish:master Nov 27, 2022
@bobthecow
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants