Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where geckodriver couldn't find firefox by allowing user to specify firefox path #99

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

OwOHamper
Copy link

  • Fixed a bug where geckodriver couldn't find firefox by allowing user to specify firefox path
    You can specify firefox path now in config: FIREFOX_PATH
  • Fixed a bug where running make_video multiple times would not update the path leading to path already exists error
    This happened for example if you were import make video from python script and making multiple videos

@OwOHamper OwOHamper mentioned this pull request Feb 11, 2023
@offish offish changed the base branch from master to v2.0.0 April 3, 2023 12:03
@offish offish merged commit b2f09d0 into offish:v2.0.0 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants