Add UI editor #128
Merged
Add UI editor #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gilliginsisland <gil@broochian.com>
|
How does this one relate to #125 ? |
Different aproach, #125 rewrites A LOT of stuff, from scratch, it's even hard to review all that code. (Althought it seems that implements extra new features, which is cool, but I never tested) This one just pigbacks the already native UI editor from the native Vertical Stack card |
|
Sounds great. Maybe additional features in #125 can be implemented after your PR was merged. @ofekashery what's blocking this PR? |
|
Thanks, @sdrapha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ui-editor by importing the native HA existing editor for vertical and horizontal cards