Unable to compile with Visual Studio 2019 and vcpkg #94
Comments
|
Hey, thanks for reporting. This error means that quill is trying to import the bundled version of libfmt, which does not exist. For vckpg we depend on lib fmt installed by vcpkg. You should not get this error. Quill does https://github.com/odygrd/quill/blob/master/CMakeLists.txt#L127 And in vcpkg it is called as https://github.com/microsoft/vcpkg/blob/8ede7e82b2fe816803c023a201c017cca0d6238a/ports/quill/portfile.cmake#L17 I see that in vcpkg last month they did this: I don't know the reason they did this but i suspect this broke it |
|
I have tried on windows with vcpkg and I can compile without issues. .\vcpkg.exe install quill:x86-windows cmake which i ran passing project(main VERSION 1.0.0) find_package(quill CONFIG REQUIRED)
|
It's the opposite actually, that's the issue I fixed with this commit. The QUILL_FMT_EXTERNAL macro need to be defined during the library build, or it won't find the bundled fmt library because we don't provide it (we use the vcpkg fmt port instead). When you install Quill via vcpkg, everything is fine because this macro is defined by the CMake file. But when you try to build a project using Quill, it fails because you're not using the CMake file and the macro isn't defined anymore. Uncomment this macro in the Quill tweak file, or update to a newest vcpkg version and the problem should be gone. :) |
|
Thank you very much @odygrd and @RT222, I've updated vcpkg and reinstalled quill, and everything works fine... Or should I say almost everything? Indeed, I faced a really weird behaviour in my project. I make use of Direct3D9 and DirectXMath (among others dependencies), and I found something strange. Here is a minimalist example: Direct3D9.hpp #pragma once
// Direct3D includes
#include <d3d9.h>
#include <DirectXMath.h>
#ifndef D3D9_IMPORTED
#pragma comment (lib, "d3d9.lib")
#define D3D9_IMPORTED 1
#endifmain.cpp // Project includes
#include "Direct3D9.hpp"
// Quill includes
#include <quill/Quill.h>
int main()
{
// We only define a matrix to be sure that there isn't any issue with DirectXMath
DirectX::XMMATRIX m = DirectX::XMMatrixIdentity();
// Below is the quill standard example to ensure everything works
quill::start();
quill::Logger* logger = quill::get_logger();
logger->set_log_level(quill::LogLevel::Info);
LOG_INFO(logger, "A simple test.\n");
return 0;
}When I compile this small project, it fails and produces the following output: For some reason, Quill does not compile in this case. The same happens when I try to compile with CMake instead of Visual Studio, with the following CMakeLists.txt: cmake_minimum_required(VERSION 3.1.0)
project(QuillTest)
set(CMAKE_CXX_STANDARD 14)
find_package(quill CONFIG REQUIRED)
add_executable(QuillTest "main.cpp" "Direct3D9.hpp")
target_link_libraries(QuillTest PRIVATE quill::quill)Note that I only tried in x64 (Debug and Release) configuration. However, if I include So, is there anything that I miss somewhere ? Did I make any mistake in the CMakeLists or in the way I include / import DirectX libraries? Eventually, I can compile, I just need to include |
|
I wonder is quill is calling a function somewhere but |
|
@Armillus thanks for reporting. I could reproduce and will fix it in the next release. For now, can you try to define NOMINMAX before including everything ? For me it worked |
|
This should be fixed in commit 519f59e |
|
@Armillus after this PR is merged microsoft/vcpkg#16931 you should upgrade to version |
Hello,
I don't know if this is the appropriate place for this issue since I don't know who is the maintainer of the vpckg quill package, let me know if I should make a similar issue directly on vcpkg.
Tools used
Builds have been done on both x86 and x64, Debug and Release modes.
Code snippet
Nothing unusual here, I reduced the code and the dependencies to the minimum and the problem still persists.
What is the problem?
I was looking for a fast and lightweight logger, and quill appeared to me as the perfect library to use. However, I'm working with Visual Studio and there is an annoying issue with vcpkg concerning quill.
When I try to compile, I get a long list of errors, which seem to come from the bundled version of fmt inside of quill.
Here is the output of the build (the actual error list of VS is composed of 32 errors, but they're all coming from the fmt integration):
Of course, I can't compile nor run the program, but the IDE isn't recognizing properly the code after
quill::Logger* logger = quill::get_logger();. On next line, it complains during static analysis about theloggerobject (C++ pointer to incomplete class type is not allowed).What about CMake?
When it comes to CMake, everything is working well, the vcpkg integrations works nicely and I don't have any error.
For the sake of accuracy and completeness, here is the CMakeLists.txt that I used.
Eventually, this error seems to come from the vcpkg package itself and maybe you'll have an idea about how to fix it.
I can still compile with CMake, but I don't use it in the project where I plan to use quill and the IDE integration failure is quite disturbing.
Thank you in advance for your help!
The text was updated successfully, but these errors were encountered: