Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sonarcloud.io auto-scanning #590

Closed
planetf1 opened this issue Jan 22, 2019 · 5 comments
Closed

Enable sonarcloud.io auto-scanning #590

planetf1 opened this issue Jan 22, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@planetf1
Copy link
Member

Currently our ODPi Sonar scanning is not working.

I can scan using sonarcloud.io, but it has to be initialized manually, and run locally. This can impede other team members from getting results from code improvements.

Sonarcloud have now launched a feature to scan automatically
https://community.sonarsource.com/t/beta-automatic-analysis-of-your-repositories-with-sonarcloud/5791

I propose adding the requirement configuration to master to enable this.
@planetf1 planetf1 added the enhancement New feature or request label Jan 22, 2019
@planetf1 planetf1 self-assigned this Jan 22, 2019
@planetf1
Copy link
Member Author

FYI @davidradl

@planetf1
Copy link
Member Author

Note: the sonarcloud.io scan does fall over on a memory issue when manually scanning.
There is no way to specify dup exclusions in this auto-scan properties file (I have contacted sonarcloud to ask
Since the only test is to commit to master, and then review the results I propose we merge this first change anyway, and then review the results

@planetf1
Copy link
Member Author

Note: scans can be found at https://sonarcloud.io/dashboard?id=planetf1_egeria (for the manual version)

@planetf1 planetf1 mentioned this issue Jan 22, 2019
Merged
@planetf1
Copy link
Member Author

Note: It also seems sonarcloud.io needs to be setup on the ODPi github account to enable this. A request has been sent. @mandy-chessell what do you think?

mandy-chessell added a commit that referenced this issue Jan 24, 2019
@mandy-chessell
Merge pull request #591 from planetf1/sonar1
a099e1c 
#590 enable sonarcloud.io auto scanning
@planetf1 planetf1 removed their assignment Mar 7, 2019
@planetf1
Copy link
Member Author

planetf1 commented Jul 5, 2019

our regular odpi scans are no wsonarcloud so closing

@planetf1 planetf1 closed this as completed Jul 5, 2019
bogdan-sava pushed a commit that referenced this issue Aug 30, 2019
@planetf1
#590 enable sonarcloud.io auto scanning
2ac0a25 
Signed-off-by: Nigel Jones <nigel.l.jones+git@gmail.com>
bogdan-sava pushed a commit that referenced this issue Aug 30, 2019
@mandy-chessell
Merge pull request #591 from planetf1/sonar1
833b0a5 
#590 enable sonarcloud.io auto scanning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@planetf1