Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

258: Wait for PostgreSQL before starting Odoo #259

Closed
wants to merge 1 commit into from
Closed

258: Wait for PostgreSQL before starting Odoo #259

wants to merge 1 commit into from

Conversation

rbuisson
Copy link
Contributor

See issue #258

@rbuisson rbuisson changed the title 258: Wait for PostgreSQL to start before start Odoo 258: Wait for PostgreSQL to start before Odoo starts Jul 16, 2019
@rbuisson rbuisson changed the title 258: Wait for PostgreSQL to start before Odoo starts 258: Wait for PostgreSQL before starting Odoo Jul 16, 2019
@rbuisson
Copy link
Contributor Author

In Debian Stretch (Odoo 11 and 12) the wait-for-it script is available as a package. This it just needs to be installed via apt install.
In Debian Jessie (Odoo 10) however, it needs to be manually provided to the system. I have added this script as a resource and copied it via Dockerfile.

@talnetd
Copy link

talnetd commented Jul 17, 2019

This is a good find. I have been aching for this wait-for-it down to TCP level.

@rbuisson
Copy link
Contributor Author

@d-fence , do you think the above makes sense?

@rbuisson
Copy link
Contributor Author

Hi @d-fence @rakete, what would be the process to get approval on this PR?
(Or any PR in general? Is there a IRC/Slack channel where a contributor can reach out to you?)

@rbuisson rbuisson force-pushed the master branch 2 times, most recently from 77a0d33 to 79f0591 Compare October 15, 2019 11:52
@rbuisson
Copy link
Contributor Author

Just updated the PR to add Odoo 13 and remove 10.
(@d-fence )

d-fence
d-fence requested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@d-fence d-fence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could squash the two commits in order to get rid of the never used bash script in git history

@rbuisson
Copy link
Contributor Author

Should be good now. @d-fence

@d-fence d-fence closed this in 14e51ae Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-fence d-fence d-fence requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbuisson @talnetd @d-fence