[Fix] Use fabs as floating point abs function in C++ (mlc-ai#1202)

octoml · Nov 5, 2023 · 3413d17 · 3413d17
1 parent 145a984
commit 3413d17
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cpp/llm_chat.cc b/cpp/llm_chat.cc
@@ -997,15 +997,15 @@ class LLMChat {
     }
     if (generation_config.count("presence_penalty")) {
       CHECK(generation_config["presence_penalty"].is<double>());
-      CHECK(abs(generation_config["presence_penalty"].get<double>()) <= 2)
+      CHECK(fabs(generation_config["presence_penalty"].get<double>()) <= 2)
           << "Presence penalty must be in the range -2 to 2!";
       *gen_presence_penalty = generation_config["presence_penalty"].get<double>();
     } else {
       *gen_presence_penalty = this->presence_penalty_;
     }
     if (generation_config.count("frequency_penalty")) {
       CHECK(generation_config["frequency_penalty"].is<double>());
-      CHECK(abs(generation_config["frequency_penalty"].get<double>()) <= 2)
+      CHECK(fabs(generation_config["frequency_penalty"].get<double>()) <= 2)
           << "Frequency penalty must be in the range -2 to 2!";
       *gen_frequency_penalty = generation_config["frequency_penalty"].get<double>();
     } else {