Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+angstrom.0.13.0 #15985

Merged
merged 4 commits into from
Mar 14, 2020
Merged

+angstrom.0.13.0 #15985

merged 4 commits into from
Mar 14, 2020

Conversation

seliopou
Copy link
Contributor

No description provided.

@kit-ty-kate
Copy link
Member

It seems that all packages added here require to increase their lower-bound constraints for OCaml to 4.04:

#=== ERROR while compiling angstrom.0.13.0 ====================================#
# context              2.0.6 | linux/x86_64 | ocaml-base-compiler.4.03.0 | pinned(https://github.com/inhabitedtype/angstrom/archive/0.13.0.tar.gz)
# path                 ~/.opam/4.03/.opam-switch/build/angstrom.0.13.0
# command              ~/.opam/4.03/bin/dune build -p angstrom -j 72
# exit-code            1
# env-file             ~/.opam/log/angstrom-23-6ed0d4.env
# output-file          ~/.opam/log/angstrom-23-6ed0d4.out
### output ###
#       ocamlc lib/.angstrom.objs/byte/angstrom.{cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.03/bin/ocamlc.opt -w -40 -safe-string -g -bin-annot -I lib/.angstrom.objs/byte -I /home/opam/.opam/4.03/lib/bigarray-compat -I /home/opam/.opam/4.03/lib/bigstringaf -intf-suffix .ml -no-alias-deps -open Angstrom__ -o lib/.angstrom.objs/byte/angstrom.cmo -c -impl lib/angstrom.ml)
# File "lib/angstrom.ml", line 490, characters 16-32:
# Error: Unbound value Sys.backend_type
#     ocamlopt lib/.angstrom.objs/native/angstrom.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.03/bin/ocamlopt.opt -w -40 -safe-string -g -I lib/.angstrom.objs/byte -I lib/.angstrom.objs/native -I /home/opam/.opam/4.03/lib/bigarray-compat -I /home/opam/.opam/4.03/lib/bigstringaf -intf-suffix .ml -no-alias-deps -open Angstrom__ -o lib/.angstrom.objs/native/angstrom.cmx -c -impl lib/angstrom.ml)
# File "lib/angstrom.ml", line 490, characters 16-32:
# Error: Unbound value Sys.backend_type

@camelus
Copy link
Contributor

camelus commented Mar 13, 2020 •
edited
Loading

Commit: 3184bfe

A pull request by opam-seasoned @seliopou.

☀️ All lint checks passed 3184bfe
  • These packages passed lint tests: angstrom-async.0.13.0, angstrom-lwt-unix.0.13.0, angstrom-unix.0.13.0, angstrom.0.13.0
☀️ Installability check (+4)
  • new installable packages (4): angstrom.0.13.0 angstrom-async.0.13.0 angstrom-lwt-unix.0.13.0 angstrom-unix.0.13.0

seliopou and others added 3 commits March 14, 2020 13:16
@seliopou
angstrom.0.13.0: ocaml > 4.04.0 for angstrom
09b1623 
All other packages are fine with to work with previous versions of
angstrom and do not require further ocaml version constraints.
@mseri
angstrom-async: remove redundant opam field
3184bfe
@mseri
angstrom-lwt-unix: dune should not be a build dependency
2a6f135
@mseri
Copy link
Member

mseri commented Mar 14, 2020

@seliopou can you upstream the two fixes above?

@mseri mseri merged commit b3756a6 into ocaml:master Mar 14, 2020
seliopou added a commit to inhabitedtype/angstrom that referenced this pull request Mar 16, 2020
@seliopou
Merge pull request #194 from kevinji/make-opam-changes
a9c4429 
opam: Copy changes from ocaml/opam-repository#15985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consider for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seliopou @kit-ty-kate @camelus @mseri