bug in sql.md: fix the query to ignore nulls #1738
Merged
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And this is how it looks like under the duckdb-1.29 branch |
|
And sometimes when I'm just fiddling with the code block, it looks like this: even if I'm not changing the query! |
|
This seems to be an issue with the native handling of arrow tables in |
|
now that I understand why it happens, maybe it's better to fix it also independently of Plot’s observablehq/plot#2194 |
mbostock
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see this bug in the last chart of https://observablehq.com/framework/sql
this spurious rect corresponds to datum 34 which has mag1 = mag2 = null. Plot does not handle correctly the
nulls in arrow vectors.It's still unclear to me why it does not happen all the time, and why it happens at all.