Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS to request review from reviewers team #613

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Update CODEOWNERS to request review from reviewers team #613

merged 1 commit into from
Jul 2, 2020

Conversation

JoelSpeed
Copy link
Member

This means that we can keep the list of reviewers up to date based on team membership, rather than this file. Will make it easier to add and remove people going forward

@JoelSpeed JoelSpeed force-pushed the update-codeowners branch from 2ac8e1b to 5670b30 Compare June 14, 2020 14:46
@JoelSpeed JoelSpeed force-pushed the update-codeowners branch from 5670b30 to 40729e9 Compare June 28, 2020 12:28
@JoelSpeed
Update CODEOWNERS to request review from reviewers team
838345c 
This means that we can keep the list of reviewers up to date based on team membership, rather than this file. Will make it easier to add and remove people going forward
@JoelSpeed JoelSpeed force-pushed the update-codeowners branch from 40729e9 to 838345c Compare July 1, 2020 20:20
NickMeves
NickMeves approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@NickMeves NickMeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoelSpeed
Copy link
Member Author

Let's hope this works 😅

@JoelSpeed JoelSpeed merged commit 390d479 into master Jul 2, 2020
@JoelSpeed JoelSpeed deleted the update-codeowners branch July 5, 2020 09:02
codablock pushed a commit to codablock/oauth2-proxy that referenced this pull request Jul 9, 2020
@JoelSpeed @codablock
Update CODEOWNERS to request review from reviewers team (oauth2-proxy…
760cdcd 
…#613)

This means that we can keep the list of reviewers up to date based on team membership, rather than this file. Will make it easier to add and remove people going forward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickMeves NickMeves NickMeves approved these changes

@steakunderscore steakunderscore Awaiting requested review from steakunderscore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelSpeed @NickMeves