Fix Linting Errors #1835
Merged
Fix Linting Errors #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andrewphamade@gmail.com <andrewphamade@gmail.com>
Signed-off-by: Andrew Hamade <andrewphamade@gmail.com>
Signed-off-by: Andrew Hamade <andrewphamade@gmail.com>
Signed-off-by: Andrew Hamade <andrewphamade@gmail.com>
|
Also fixes: #1646 |
|
When it says make a non master branch does it mean on my fork? |
Yes, typically we work from feature branches. There can sometimes be issues with the way our builds run if you PR from a branch called master, though I think they have been resolved now |
JoelSpeed
reviewed
Oct 16, 2022
| @@ -186,7 +186,7 @@ func (s *server) Start(ctx context.Context) error { | |||
| // When the given context is cancelled the server will be shutdown. | |||
| // If any errors occur, only the first error will be returned. | |||
| func (s *server) startServer(ctx context.Context, listener net.Listener) error { | |||
| srv := &http.Server{Handler: s.handler} | |||
| srv := &http.Server{Handler: s.handler, ReadHeaderTimeout: time.Minute} | |||
There was a problem hiding this comment.
Where did this one come from?
There was a problem hiding this comment.
This is to mitigate a potential slowloris attack. https://medium.com/a-journey-with-go/go-understand-and-mitigate-slowloris-attack-711c1b1403f6
I suppose we could make it configurable, but having this unset leaves the server vulnerable.
Signed-off-by: Andrew Hamade <andrewphamade@gmail.com>
3 tasks
JoelSpeed
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed linting errors. I also found a possible slowloris error and fixed that as well:
https://github.com/devopstagon/oauth2-proxy/blob/master/pkg/http/server.go#L189
https://medium.com/a-journey-with-go/go-understand-and-mitigate-slowloris-attack-711c1b1403f6
Motivation and Context
I wanted to try and work on the Azure provider a bit, but I figured it would be a good idea to preemptively merge this into master first to have a "clean" base to work from.
How Has This Been Tested?
I ran make and also built an image and tested it in my environment.
Checklist: